Re: [PATCH] dt-bindings: leds: leds-gpio: fix & extend node regex
From: Rob Herring <robh@kernel.org>
Date: 2021-03-16 22:32:15
Also in:
linux-leds
On Wed, Mar 10, 2021 at 08:00:25AM +0100, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@milecki.pl> The old regex allowed only 1 character to follow the "led-" prefix which was most likely just an overlook.
Indeed.
Fix it and while at it allow dashes in node names. It allows more meaningful names and it helpful e.g. when having the same function name with 2 different colors. For example: 1. led-power-white 2. led-power-blue
No, node names are supposed to be generic and reflect the class of device.
quoted hunk ↗ jump to hunk
Signed-off-by: Rafał Miłecki <rafal@milecki.pl> --- Documentation/devicetree/bindings/leds/leds-gpio.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.yaml b/Documentation/devicetree/bindings/leds/leds-gpio.yaml index 7ad2baeda0b0..ae46a43e480f 100644 --- a/Documentation/devicetree/bindings/leds/leds-gpio.yaml +++ b/Documentation/devicetree/bindings/leds/leds-gpio.yaml@@ -21,7 +21,7 @@ properties: patternProperties: # The first form is preferred, but fall back to just 'led' anywhere in the # node name to at least catch some child nodes. - "(^led-[0-9a-f]$|led)": + "(^led-[0-9a-f][0-9a-f-]*$|led)": type: object $ref: common.yaml#-- 2.26.2