Thread (21 messages) 21 messages, 3 authors, 2021-03-30

Re: [PATCH v1 5/6] dt-bindings: memory: tegra20: emc: Convert to schema

From: Rob Herring <robh@kernel.org>
Date: 2021-03-30 22:34:49
Also in: linux-tegra, lkml

On Tue, Mar 30, 2021 at 06:56:44PM +0300, Dmitry Osipenko wrote:
30.03.2021 18:29, Dmitry Osipenko пишет:
quoted
30.03.2021 11:48, Krzysztof Kozlowski пишет:
quoted
quoted
+  power-domains:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      Phandle of the SoC "core" power domain.
I think the core checks the type, so you only need to limit max items.
It's a bit confusing that both variants work and it's not apparent what
variant is better.
Soon '$ref' won't work. I have a pending meta-schema change to catch 
this. It takes some time because I have to fix all the existing cases in 
tree and wait a cycle so I'm not breaking everyone. 
quoted
I actually used the max items limit initially and then changed it to
$ref phandle because it appeared to me that it's a better choice. I'll
switch back to the limit in v2, thanks.
Although, I'm still not sure what is the best variant. Could you please
clarify why maxItems is better?

Seems the $ref phandle already limits domain items to 1. So I don't
understand what's the difference.
It would not work with '<&domain 1>' as 'phandle' doesn't accept any 
arg cells. While you may know you don't have any cells, technically 
that's provider dependent and outside the scope of this binding.

Rob


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help