Thread (43 messages) 43 messages, 5 authors, 2021-06-25

Re: [PATCH 17/17] auxdisplay: ht16k33: Add segment display LED support

From: Pavel Machek <hidden>
Date: 2021-03-27 22:20:09
Also in: linux-leds, linux-mips, lkml

Hi!
quoted
quoted
quoted
quoted
-     err = ht16k33_brightness_set(priv, MAX_BRIGHTNESS);
+     of_property_read_u32(node, "color", &color);
+     seg->led.name = devm_kasprintf(dev, GFP_KERNEL,
+                     DRIVER_NAME ":%s:" LED_FUNCTION_BACKLIGHT,
+                     color < LED_COLOR_ID_MAX ? led_colors[color] : "");
And would prefer not to see driver_name as part of LED name.
OK. So what should I use instead? Or just leave the part before the
first colon empty?
I'd suggest auxdisplay:...:backlight.

And we should start documenting this somewhere.

Best regards,
									Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help