Thread (10 messages) 10 messages, 2 authors, 2021-03-26

Re: [PATCH v5 9/9] dt-bindings: serial: stm32: Use 'type: object' instead of false for 'additionalProperties'

From: dillon min <hidden>
Date: 2021-03-26 01:55:21
Also in: linux-arm-kernel, linux-serial, lkml

Hi Valentin

On Thu, Mar 25, 2021 at 7:12 PM Valentin CARON - foss
[off-list ref] wrote:
Hi Dillon,

It's okay for me.

Regards,

Valentin
Thanks for your test, and quick reply.
On 3/25/21 7:19 AM, dillon.minfei@gmail.com wrote:
quoted
From: dillon min <redacted>

To use additional properties 'bluetooth' on serial, need replace false with
'type: object' for 'additionalProperties' to make it as a node, else will
run into dtbs_check warnings.

'arch/arm/boot/dts/stm32h750i-art-pi.dt.yaml: serial@40004800:
'bluetooth' does not match any of the regexes: 'pinctrl-[0-9]+'

Fixes: af1c2d81695b ("dt-bindings: serial: Convert STM32 UART to json-schema")
Reported-by: kernel test robot <redacted>
Tested-by: Valentin Caron <redacted>
Signed-off-by: dillon min <redacted>
---

v5: accroding to rob's suggestion, replace false with 'type: object'
     of 'additionalProperties'.

  Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
index 8631678283f9..865be05083c3 100644
--- a/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/st,stm32-uart.yaml
@@ -80,7 +80,8 @@ required:
    - interrupts
    - clocks

-additionalProperties: false
+additionalProperties:
+  type: object

  examples:
    - |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help