Re: [PATCH 3/6] drm/rockchip: dsi: add ability to work as a phy instead of full dsi

Am Montag, 15. Februar 2021, 15:33:19 CET schrieb Helen Koike:

quoted

From: Heiko Stuebner <redacted>

diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index cb25c0e8fc9b..3094d4533ad6 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig

@@ -9,6 +9,8 @@ config DRM_ROCKCHIP
  	select DRM_ANALOGIX_DP if ROCKCHIP_ANALOGIX_DP
  	select DRM_DW_HDMI if ROCKCHIP_DW_HDMI
  	select DRM_DW_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI
+	select GENERIC_PHY if ROCKCHIP_DW_MIPI_DSI
+	select GENERIC_PHY_MIPI_DPHY if ROCKCHIP_DW_MIPI_DSI

maybe alphabetical order?

ok

quoted

+static int dw_mipi_dsi_dphy_power_on(struct phy *phy)
+{
+	struct dw_mipi_dsi_rockchip *dsi = phy_get_drvdata(phy);
+	int i, ret;

It seems "i" could be removed, use ret instead.

I don't think so

I.e. the driver does

	i = max_mbps_to_parameter(...)
	...
	ret = power-on-clocks-and-stuff
	...
	dw_mipi_dsi_phy_write(.... dppa_map[i].hsfreqrange)

So will need to keep the param index separate.

In general, the patch doesn't look wrong to me.

For the whole serie:
Acked-by: Helen Koike <redacted>

Thanks a lot :-)


Heiko