On Tue, Mar 23, 2021 at 08:22:00PM +0000, Chris Packham wrote:

Hi Rob,

On 24/03/21 9:16 am, Rob Herring wrote:

quoted

On Tue, 23 Mar 2021 17:33:27 +1300, Chris Packham wrote:

quoted

Convert i2c-mpc to YAML.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
  .../devicetree/bindings/i2c/i2c-mpc.txt       | 62 ------------
  .../devicetree/bindings/i2c/i2c-mpc.yaml      | 99 +++++++++++++++++++
  2 files changed, 99 insertions(+), 62 deletions(-)
  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mpc.txt
  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mpc.yaml

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/i2c/i2c-mpc.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/i2c/i2c-mpc.yaml:20:11: [warning] wrong indentation: expected 12 but found 10 (indentation)

Hmm I did run 'make dt_binding_check' is yamllint run separately (or not 
run if it's not installed?).

No and yes...

quoted

dtschema/dtc warnings/errors:

See https://patchwork.ozlabs.org/patch/1457053

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

^^^^^

quoted

pip3 install dtschema --upgrade

Please check and re-submit.

Should be easy to fix the binding but I'll spend a bit of time trying to 
get my tooling sorted.