On 22/03/2021 17:28, Rob Herring wrote:

On Mon, Mar 22, 2021 at 10:53 AM Suzuki K Poulose
[off-list ref] wrote:

quoted

Hi Rob

On 06/03/2021 21:06, Rob Herring wrote:

quoted

On Thu, Feb 25, 2021 at 07:35:39PM +0000, Suzuki K Poulose wrote:

quoted

Document the device tree bindings for Embedded Trace Extensions.
ETE can be connected to legacy coresight components and thus
could optionally contain a connection graph as described by
the CoreSight bindings.

Cc: devicetree@vger.kernel.org
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <redacted>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---

quoted

quoted

quoted

+  out-ports:
+    description: |
+      Output connections from the ETE to legacy CoreSight trace bus.
+    $ref: /schemas/graph.yaml#/properties/port

s/port/ports/

Ok.

quoted

And then you need:

         properties:
           port:
             description: what this port is
             $ref: /schemas/graph.yaml#/properties/port

Isn't this already covered by the definition of ports ? There are no
fixed connections for ETE. It is optional and could be connected to
any legacy CoreSight component. i.e, a "ports" object can have port
objects inside.

'properties/ports' only defines that you have 'port' nodes within it.

quoted

Given we have defined out-ports as an object "confirming to the ports"
do we need to describe the individual port nodes ?

Yes, you have to define what the 'port' nodes are. A port is a data
stream and you should know what your hardware has. What the data
stream is connected to is outside the scope of the binding.

Ok, I have included the above changes for the next version.

Thanks
Suzuki