Thread (5 messages) 5 messages, 2 authors, 2021-03-23

Re: [PATCH V5 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5

From: Lee Jones <hidden>
Date: 2021-03-22 17:35:17
Also in: dri-devel, linux-arm-msm, linux-fbdev, linux-leds, lkml, phone-devel

On Thu, 18 Mar 2021, Kiran Gunda wrote:
Currently, for WLED5, the FSC (Full scale current) setting is not
updated properly due to driver toggling the wrong register after
an FSC update.

On WLED5 we should only toggle the MOD_SYNC bit after a brightness
update. For an FSC update we need to toggle the SYNC bits instead.

Fix it by adopting the common wled3_sync_toggle() for WLED5 and
introducing new code to the brightness update path to compensate.

Signed-off-by: Kiran Gunda <redacted>
Reviewed-by: Daniel Thompson <redacted>
---
 drivers/video/backlight/qcom-wled.c | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)
Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help