Hi Robin,

On Mon, Mar 15, 2021 at 5:32 PM Robin Murphy [off-list ref] wrote:

On 2021-03-13 13:22, CN_SZTL wrote:

quoted

Robin Murphy [off-list ref] 于2021年3月13日周六 下午7:55写道：

quoted

On 2021-03-13 03:25, Tianling Shen wrote:

quoted

+     gpio-leds {
+             compatible = "gpio-leds";
+             pinctrl-0 = <&lan_led_pin>, <&sys_led_pin>, <&wan_led_pin>;
+             pinctrl-names = "default";
+
+             lan_led: led-0 {
+                     gpios = <&gpio1 RK_PA1 GPIO_ACTIVE_HIGH>;
+                     label = "nanopi-r4s:green:lan";
+             };
+
+             sys_led: led-1 {
+                     gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>;
+                     label = "nanopi-r4s:red:sys";
+                     default-state = "on";
+             };
+
+             wan_led: led-2 {
+                     gpios = <&gpio1 RK_PA0 GPIO_ACTIVE_HIGH>;
+                     label = "nanopi-r4s:green:wan";
+             };

Nit: (apologies for overlooking it before) there isn't an obvious
definitive order for the LEDs, but the order here is certainly not
consistent with anything. The most logical would probably be sys, wan,

Looks like alphabetical sort order to me ;-)

lan since that's both in order of GPIO number and how they are
physically positioned relative to each other on the board/case (although
you could also argue for wan, lan, sys in that regard, depending on how
you look at it).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds