Re: [PATCH v2] arm64: defconfig: enable Intel's eASIC N5X SoCFPGA and Keem Bay SoC

On Tue, Mar 9, 2021 at 2:26 PM Dinh Nguyen [off-list ref] wrote:

On 3/9/21 3:29 AM, Krzysztof Kozlowski wrote:

quoted

On 08/03/2021 20:07, Dinh Nguyen wrote:

quoted

quoted

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d612f633b771..9f9adcb8b0e9 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig

@@ -29,6 +29,7 @@ CONFIG_KALLSYMS_ALL=y
   CONFIG_PROFILING=y
   CONFIG_ARCH_ACTIONS=y
   CONFIG_ARCH_AGILEX=y
+CONFIG_ARCH_N5X=y

I just submitted a patch for this as well. From the looks of the
defconfig file, it looks like the platforms are in alphabetical order,
but then I see that ARCH_SUNXI is not in it's correct spot if there is a
rule for keeping things in alphabetical order.

The rule is that order comes from savedefconfig, not alphabetical. This
way you avoid reshuffling of symbols on any future savedefconfig.

Got it. But I've done savedefconfig in the past and Arnd adviced against
that because what if multiple patches come in with savedefconfig,
wouldn't that cause a messy merge?

To clarify: you should not send the result of 'make savedefconfig'
if it changes the contents of the file in another way, but Krzysztof's
recommendation of adding new lines where savedefconfig would
put them is best.

        Arnd