Re: [PATCH v4 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900
From: Rob Herring <robh@kernel.org>
Date: 2021-03-05 22:59:19
Also in:
linux-media, lkml
On Fri, Feb 19, 2021 at 09:15:13AM +0100, Maxime Chevallier wrote:
The Techwell TW9900 is a video decoder supporting multiple input standards, such as PAL, NTSC and SECAM, and outputs a BT.656 video signal. It's designed to be low-power, posesses some features such as a programmable comb-filter, and automatic input standard detection. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- V2->V3 : Fix the example not compiling due to a typo in the reset-gpios node. V3->V4 : Add the missing reset-gpios node to the binding .../devicetree/bindings/media/i2c/tw9900.yaml | 64 +++++++++++++++++++
Use the compatible string for the filename.
quoted hunk ↗ jump to hunk
1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/tw9900.yamldiff --git a/Documentation/devicetree/bindings/media/i2c/tw9900.yaml b/Documentation/devicetree/bindings/media/i2c/tw9900.yaml new file mode 100644 index 000000000000..d27196e37416 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/tw9900.yaml@@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/tw9900.yaml#
Don't forget to update this...
+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Techwell TW9900 NTSC/PAL/SECAM video decoder + +maintainers: + - Maxime Chevallier [off-list ref] + +description: + The tw9900 is a multi-standard video decoder, supporting NTSC, PAL and SECAM + standards with auto-detection features. + +properties: + compatible: + items: + - enum: + - techwell,tw9900 + + reg: + maxItems: 1 + + vdd-supply: + description: VDD power supply + + reset-gpios: + description: GPIO descriptor for the RESET input pin + maxItems: 1 + + port: + type: object + description: + A node containing a single endpoint as doucmented in + Documentation/devicetree/bindings/media/video-interfaces.txt
It's now video-interfaces.yaml, but you aren't using anything from it. You need to reference graph.yaml though. See the examples in the tree now.
+
+additionalProperties: false
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ tw9900: tw9900@44 {
+ compatible = "techwell,tw9900";
+ reg = <0x44>;
+
+ vdd-supply = <&tw9900_supply>;
+ reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
+
+ port {
+ tw9900_out: endpoint {
+ remote-endpoint = <&vip_in>;
+ };
+ };
+ };
+ };
--
2.25.4