Thread (24 messages) 24 messages, 3 authors, 2021-03-04

Re: [PATCH v3 01/14] gpio: regmap: set gpio_chip of_node

From: Michael Walle <hidden>
Date: 2021-03-03 19:09:28
Also in: linux-arm-kernel, linux-gpio, lkml

Am 2021-03-03 15:22, schrieb Álvaro Fernández Rojas:
quoted hunk ↗ jump to hunk
This is needed for properly registering gpio regmap as a child of a 
regmap
pin controller.

Signed-off-by: Álvaro Fernández Rojas <redacted>
---
 v3: introduce patch needed for properly parsing gpio-ranges.

 drivers/gpio/gpio-regmap.c  | 1 +
 include/linux/gpio/regmap.h | 3 +++
 2 files changed, 4 insertions(+)
diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
index 5412cb3b0b2a..752ccd780b7d 100644
--- a/drivers/gpio/gpio-regmap.c
+++ b/drivers/gpio/gpio-regmap.c
@@ -249,6 +249,7 @@ struct gpio_regmap *gpio_regmap_register(const
struct gpio_regmap_config *config

 	chip = &gpio->gpio_chip;
 	chip->parent = config->parent;
+	chip->of_node = config->of_node;
chip->of_node = config->of_node ?: dev_of_node(config->parent);

As mentioned in my previous reply in this thread, for clarity
reasons.
quoted hunk ↗ jump to hunk
 	chip->base = -1;
 	chip->ngpio = config->ngpio;
 	chip->names = config->names;
diff --git a/include/linux/gpio/regmap.h b/include/linux/gpio/regmap.h
index ad76f3d0a6ba..f6e638e32d2a 100644
--- a/include/linux/gpio/regmap.h
+++ b/include/linux/gpio/regmap.h
@@ -4,6 +4,7 @@
 #define _LINUX_GPIO_REGMAP_H

 struct device;
+struct device_node;
 struct gpio_regmap;
 struct irq_domain;
 struct regmap;
@@ -14,6 +15,7 @@ struct regmap;
 /**
  * struct gpio_regmap_config - Description of a generic regmap 
gpio_chip.
  * @parent:		The parent device
+ * @of_node:		The device node
Please add "(Optional)" and move it below @regmap. This should also
mention that if not supplied parent->of_node is used.
quoted hunk ↗ jump to hunk
  * @regmap:		The regmap used to access the registers
  *			given, the name of the device is used
  * @label:		(Optional) Descriptive name for GPIO controller.
@@ -56,6 +58,7 @@ struct regmap;
  */
 struct gpio_regmap_config {
 	struct device *parent;
+	struct device_node *of_node;
 	struct regmap *regmap;

 	const char *label;
With these changes:
Reviewed-by: Michael Walle <redacted>

-michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help