Quoting Taniya Das (2021-03-01 09:27:06)

On 2/23/2021 1:13 PM, Stephen Boyd wrote:

quoted

Quoting Rajendra Nayak (2021-02-11 23:28:43)

quoted

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
+               usb3_phy_wrapper_gcc_usb30_pipe_clk: usb3-phy-wrapper-gcc-usb30-pipe-clk {
+                       compatible = "fixed-clock";
+                       clock-frequency = <1000>;
+                       #clock-cells = <0>;
+               };

Shouldn't these come from the phys? Why are they being added here?

Once the phys are added, these could be replaced, that was the reason to 
add them.

quoted

quoted

         };
  
         reserved_memory: reserved-memory {

@@ -174,6 +211,17 @@
                 gcc: clock-controller@100000 {
                         compatible = "qcom,gcc-sc7280";
                         reg = <0 0x00100000 0 0x1f0000>;
+                       clocks = <&rpmhcc RPMH_CXO_CLK>,
+                                <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
+                                <&pcie_0_pipe_clk>, <&pcie_1_pipe_clk>,
+                                <&ufs_phy_rx_symbol_0_clk>, <&ufs_phy_rx_symbol_1_clk>,
+                                <&ufs_phy_tx_symbol_0_clk>,
+                                <&usb3_phy_wrapper_gcc_usb30_pipe_clk>;

If the phys aren't ready then <0> should work. Unless something goes
wrong?

Nothing would go wrong if we add <0>, but wanted them to be replaced 
once the support is added.

Please use <0> to indicate that it's missing. Otherwise we may never
realize that we should connect it up later.