Thread (29 messages) 29 messages, 3 authors, 2021-03-02

Re: [PATCH 04/12] pinctrl: add a pincontrol driver for BCM6358

From: Linus Walleij <hidden>
Date: 2021-03-02 18:12:34
Also in: linux-gpio, lkml

On Thu, Feb 25, 2021 at 5:42 PM Álvaro Fernández Rojas
[off-list ref] wrote:
Add a pincotrol driver for BCM6358. BCM6358 allow overlaying different
functions onto the GPIO pins. It does not support configuring individual
pins but only whole groups. These groups may overlap, and still require
the directions to be set correctly in the GPIO register. In addition the
functions register controls other, not directly mux related functions.

Signed-off-by: Álvaro Fernández Rojas <redacted>
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
All of my review comments on the first driver in the series goes
for this one as well, so copy/paste all my comments from there :D

The good thing is once you get it right in one driver you will get it
right in all of them.

Consider bringing all common code together in a main driver
shared by all these pin controllers as per the pattern of other
pin controllers (se qcom for example).

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help