Re: [PATCH RESEND v5 7/8] regulator: mt6359: Add support for MT6359P regulator

On Fri, 29 Jan 2021, Hsin-Hsiung Wang wrote:

The MT6359P is a eco version for MT6359 regulator.
We add support based on MT6359 regulator driver.

Signed-off-by: Hsin-Hsiung Wang <redacted>
---
changes since v4:
- add the regulators_node support.
---
 drivers/regulator/mt6359-regulator.c       | 379 ++++++++++++++++++++-

 include/linux/mfd/mt6359p/registers.h      | 249 ++++++++++++++

Although the code is fine, just be aware that Linus can get grumpy
having 100s and 100s of unused register defines in the kernel.

 include/linux/regulator/mt6359-regulator.h |   1 +
 3 files changed, 623 insertions(+), 6 deletions(-)
 create mode 100644 include/linux/mfd/mt6359p/registers.h

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

On Mon, 2021-03-01 at 10:21 +0000, Lee Jones wrote:

On Fri, 29 Jan 2021, Hsin-Hsiung Wang wrote:

quoted

The MT6359P is a eco version for MT6359 regulator.
We add support based on MT6359 regulator driver.

Signed-off-by: Hsin-Hsiung Wang <redacted>
---
changes since v4:
- add the regulators_node support.
---
 drivers/regulator/mt6359-regulator.c       | 379 ++++++++++++++++++++-

quoted

 include/linux/mfd/mt6359p/registers.h      | 249 ++++++++++++++

Although the code is fine, just be aware that Linus can get grumpy
having 100s and 100s of unused register defines in the kernel.

Thanks for the comment. We will mull it over.

quoted

 include/linux/regulator/mt6359-regulator.h |   1 +
 3 files changed, 623 insertions(+), 6 deletions(-)
 create mode 100644 include/linux/mfd/mt6359p/registers.h