Thread (32 messages) read the whole thread 32 messages, 7 authors, 2021-02-11
STALE1995d REVIEWED: 8 (8M)

1 review trailer.

[PATCH net-next 5.12 4/8] net: broadcom: bcm4908_enet: drop unneeded memset()

From: Rafał Miłecki <zajec5@gmail.com>
Date: 2021-02-11 12:17:14
Also in: netdev
Subsystem: broadcom bcm4908 ethernet driver, networking drivers, the rest · Maintainers: Rafał Miłecki, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

From: Rafał Miłecki <rafal@milecki.pl>

dma_alloc_coherent takes care of zeroing allocated memory

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
index e56348eb188f..f4e31646d50f 100644
--- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
+++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
@@ -163,8 +163,6 @@ static int bcm4908_dma_alloc_buf_descs(struct bcm4908_enet *enet,
 	if (!ring->slots)
 		goto err_free_buf_descs;
 
-	memset(ring->cpu_addr, 0, size);
-
 	ring->read_idx = 0;
 	ring->write_idx = 0;
 
-- 
2.26.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help