Re: [PATCH v4 11/22] media: camss: Add support for CSIPHY hardware version Titan 170

Hi Robert,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on robh/for-next linus/master v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Robert-Foss/Add-support-for-the-SDM845-Camera-Subsystem/20210206-071553
base:   git://linuxtv.org/media_tree.git master
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f4da8d1038a233c7c82c8fe394cfe861745e807f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Robert-Foss/Add-support-for-the-SDM845-Camera-Subsystem/20210206-071553
        git checkout f4da8d1038a233c7c82c8fe394cfe861745e807f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

   drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c: In function 'csiphy_gen2_config_lanes':

quoted

drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:307:29: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

     307 |    struct csiphy_reg_t *r = &lane_regs_sdm845[l][i];
         |                             ^
   In file included from drivers/media/platform/qcom/camss/camss.h:21,
                    from drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:11:
   At top level:
   drivers/media/platform/qcom/camss/camss-csid.h:92:27: warning: 'csid_testgen_modes' defined but not used [-Wunused-const-variable=]
      92 | static const char * const csid_testgen_modes[] = {
         |                           ^~~~~~~~~~~~~~~~~~


vim +/const +307 drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c

   298	
   299	static void csiphy_gen2_config_lanes(struct csiphy_device *csiphy,
   300					     u8 settle_cnt)
   301	{
   302		int i, l;
   303		u32 val;
   304	
   305		for (l = 0; l < 5; l++) {
   306			for (i = 0; i < 14; i++) {
 > 307				struct csiphy_reg_t *r = &lane_regs_sdm845[l][i];
   308	
   309				switch (r->csiphy_param_type) {
   310				case CSIPHY_SETTLE_CNT_LOWER_BYTE:
   311					val = settle_cnt & 0xff;
   312					break;
   313				case CSIPHY_DNP_PARAMS:
   314					continue;
   315				default:
   316					val = r->reg_data;
   317					break;
   318				}
   319				writel_relaxed(val, csiphy->base + r->reg_addr);
   320			}
   321		}
   322	}
   323	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org