Re: [PATCH 3/3] arm64: dts: qcom: sc7180: Delete charger thermal zone and ADC channel for lazor <= rev3
From: Stephen Boyd <hidden>
Date: 2021-02-22 20:20:51
Also in:
linux-arm-msm, lkml
Quoting Matthias Kaehlcke (2021-02-19 18:10:59)
quoted hunk ↗ jump to hunk
Lazor rev3 and older are stuffed with a 47k NTC as thermistor for the charger temperature which currently isn't supported by the PM6150 ADC driver. Delete the charger thermal zone and ADC channel to avoid the use of bogus temperature values. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 9 +++++++++ arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 9 +++++++++ arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r3.dts | 9 +++++++++ 3 files changed, 27 insertions(+)diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts index 30e3e769d2b4..0974dbd424e1 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts@@ -14,6 +14,15 @@ / { compatible = "google,lazor-rev0", "qcom,sc7180"; }; +/* + * rev <= 3 are stuffed with a 47k NTC as charger thermistor which is currently + * not supported by the PM6150 ADC driver. Delete the thermal zone and ADC + * channel to avoid the use of bogus temperature values. + */ +/delete-node/ &charger_thermal; +/delete-node/ &pm6150_adc_charger_thm; +/delete-node/ &pm6150_adc_tm_charger_thm;
Can we disable pm6150_adc_tm instead on <= rev3 boards? It would be the same number of lines, but is simpler to reason about disabled nodes vs. deleted nodes usually.
+
&pp3300_hub {
/* pp3300_l7c is used to power the USB hub */
/delete-property/regulator-always-on;