Re: [PATCH v2 4/9] media: uapi: Add a control for HANTRO driver
From: Jernej Škrabec <hidden>
Date: 2021-02-18 21:35:44
Also in:
linux-arm-kernel, linux-media, linux-rockchip, lkml
Hi! Dne četrtek, 18. februar 2021 ob 20:18:39 CET je Benjamin Gaignard napisal(a):
quoted hunk ↗ jump to hunk
The HEVC HANTRO driver needs to know the number of bits to skip at the beginning of the slice header. That is a hardware specific requirement so create a dedicated control that this purpose. Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com> --- include/uapi/linux/hantro-v4l2-controls.h | 20 ++++++++++++++++++++ include/uapi/linux/v4l2-controls.h | 5 +++++ 2 files changed, 25 insertions(+) create mode 100644 include/uapi/linux/hantro-v4l2-controls.hdiff --git a/include/uapi/linux/hantro-v4l2-controls.h b/include/uapi/linux/
hantro-v4l2-controls.h
quoted hunk ↗ jump to hunk
new file mode 100644 index 000000000000..30b1999b7af3--- /dev/null +++ b/include/uapi/linux/hantro-v4l2-controls.h@@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ + +#ifndef __UAPI_HANTRO_V4L2_CONYTROLS_H__ +#define __UAPI_HANTRO_V4L2_CONYTROLS_H__ + +#include <linux/v4l2-controls.h> +#include <media/hevc-ctrls.h> + +#define V4L2_CID_HANTRO_HEVC_EXTRA_DECODE_PARAMS
(V4L2_CID_USER_HANTRO_BASE + 0)
+ +/** + * struct hantro_hevc_extra_decode_params - extra decode parameters for
hantro driver
+ * @hevc_hdr_skip_lenght: header first bits offset
+ */
+struct hantro_hevc_extra_decode_params {
+ __u32 hevc_hdr_skip_lenght;typo: lenght -> length Same mistake in description above. Best regards, Jernej
quoted hunk ↗ jump to hunk
+ __u8 padding[4]; +}; + +#endifdiff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-
controls.h
quoted hunk ↗ jump to hunk
index 039c0d7add1b..ced7486c7f46 100644--- a/include/uapi/linux/v4l2-controls.h +++ b/include/uapi/linux/v4l2-controls.h@@ -209,6 +209,11 @@ enum v4l2_colorfx { * We reserve 128 controls for this driver. */ #define V4L2_CID_USER_CCS_BASE (V4L2_CID_USER_BASE +
0x10f0)
+/* + * The base for HANTRO driver controls. + * We reserve 32 controls for this driver. + */ +#define V4L2_CID_USER_HANTRO_BASE (V4L2_CID_USER_BASE +
0x1170)
/* MPEG-class control IDs */ /* The MPEG controls are applicable to all codec controls -- 2.25.1