Re: [PATCH] of: property: fw_devlink: Ignore interrupts property for some configs

On Tue, Feb 16, 2021 at 12:20 PM Enrico Weigelt, metux IT consult
[off-list ref] wrote:

On 15.02.21 23:42, Saravana Kannan wrote:

Hi,

quoted

diff --git a/drivers/of/property.c b/drivers/of/property.c
index 79b68519fe30..5036a362f52e 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c

@@ -1300,6 +1300,9 @@ static struct device_node *parse_interrupts(struct device_node *np,
  {
      struct of_phandle_args sup_args;

+     if (!IS_ENABLED(CONFIG_OF_IRQ) || IS_ENABLED(CONFIG_PPC))
+             return NULL;
+
      if (strcmp(prop_name, "interrupts") &&
          strcmp(prop_name, "interrupts-extended"))
              return NULL;

wouldn't it be better to #ifdef-out the whole code in this case ?

No, #ifdef is not preferred. That's why we even have the IS_ENABLED()
macros in the first place. The compiled will optimize out the code.

-Saravana