On 16/02/2021 19.29, Arnd Bergmann wrote:

On Tue, Feb 16, 2021 at 11:20 AM Krzysztof Kozlowski [off-list ref] wrote:

quoted

On Tue, 16 Feb 2021 at 11:19, Arnd Bergmann [off-list ref] wrote:

quoted

quoted

quoted

+     return samsung_early_console_setup(device, opt);

Don't you need to handle the error code - set PROT_DEFAULT() or whatever
was there before?

__set_fixmap() has no return value, it just writes a page table entry and
does not fail.

I meant, handle samsung_early_console_setup() error code (NULL).

Ah, I see.

I don't think it makes a difference -- if ->setup() fails, the page table entry
is just left in place unused, and the type of the unused mapping doesn't
matter. If earlycon tried to unmap the page, the type also would not
change anything.

With earlycon, I'd generally lean towards keeping things as simple as possible,
in order to increase the chance of seeing anything at all. It clearly wouldn't
hurt to try to add minimal error handling here.

There's no logic to clean this up in earlycon itself anyway, so there's 
no point in trying to do it for the override. If another earlycon driver 
ends up getting instantiated for some reason, it will override the 
mapping with a normal one again.


-- 
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub