Re: [PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2021-02-15 09:04:57
Also in:
linux-arm-kernel, linux-iio, linux-samsung-soc, lkml
Hi Krzysztof, On 12.02.2021 17:38, Krzysztof Kozlowski wrote:
Add common properties appearing in DTSes (assigned-clocks and similar)
to fix dtbs_check warnings like:
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'Does it mean that assigned-clocks related properties have to be added to almost all bindings? IMHO this is an over-engineering and this has to be handled somewhere else...
quoted hunk ↗ jump to hunk
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- .../bindings/iio/adc/samsung,exynos-adc.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml index c65921e66dc1..ce03132f8ebc 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml@@ -27,6 +27,18 @@ properties: reg: maxItems: 1 + assigned-clocks: + minItems: 1 + maxItems: 3 + + assigned-clock-parents: + minItems: 1 + maxItems: 3 + + assigned-clock-rates: + minItems: 1 + maxItems: 3 + clocks: description: Phandle to ADC bus clock. For Exynos3250 additional clock is needed.
Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland