[PATCH] dt-bindings: iio: samsung,exynos-adc: add common clock properties

Add common properties appearing in DTSes (assigned-clocks and similar)
to fix dtbs_check warnings like:

  arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
    adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
  arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
    adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 .../bindings/iio/adc/samsung,exynos-adc.yaml         | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
index c65921e66dc1..ce03132f8ebc 100644
--- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml

@@ -27,6 +27,18 @@ properties:
   reg:
     maxItems: 1
 
+  assigned-clocks:
+    minItems: 1
+    maxItems: 3
+
+  assigned-clock-parents:
+    minItems: 1
+    maxItems: 3
+
+  assigned-clock-rates:
+    minItems: 1
+    maxItems: 3
+
   clocks:
     description:
       Phandle to ADC bus clock. For Exynos3250 additional clock is needed.

-- 
2.25.1

Hi Krzysztof,

On 12.02.2021 17:38, Krzysztof Kozlowski wrote:

Add common properties appearing in DTSes (assigned-clocks and similar)
to fix dtbs_check warnings like:

   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Does it mean that assigned-clocks related properties have to be added to 
almost all bindings? IMHO this is an over-engineering and this has to be 
handled somewhere else...

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote:

Hi Krzysztof,

On 12.02.2021 17:38, Krzysztof Kozlowski wrote:

quoted

Add common properties appearing in DTSes (assigned-clocks and similar)
to fix dtbs_check warnings like:

   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Does it mean that assigned-clocks related properties have to be added to 
almost all bindings?

To my understanding: yes, and we already added it to multiple schemas.

IMHO this is an over-engineering and this has to be 
handled somewhere else...

Would have to be made a part of the core schema (just like pinctrl nodes
etc).

Best regards,
Krzysztof

On Mon, Feb 15, 2021 at 10:29:15AM +0100, Krzysztof Kozlowski wrote:

On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote:

quoted

Hi Krzysztof,

On 12.02.2021 17:38, Krzysztof Kozlowski wrote:

quoted

Add common properties appearing in DTSes (assigned-clocks and similar)
to fix dtbs_check warnings like:

   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Does it mean that assigned-clocks related properties have to be added to 
almost all bindings?

To my understanding: yes, and we already added it to multiple schemas.

quoted

IMHO this is an over-engineering and this has to be 
handled somewhere else...

Would have to be made a part of the core schema (just like pinctrl nodes
etc).

That's the case now. It's contingent on having a 'clocks' property in 
the node.

Rob

On 05/03/2021 21:41, Rob Herring wrote:

On Mon, Feb 15, 2021 at 10:29:15AM +0100, Krzysztof Kozlowski wrote:

quoted

On Mon, Feb 15, 2021 at 10:01:48AM +0100, Marek Szyprowski wrote:

quoted

Hi Krzysztof,

On 12.02.2021 17:38, Krzysztof Kozlowski wrote:

quoted

Add common properties appearing in DTSes (assigned-clocks and similar)
to fix dtbs_check warnings like:

   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clock-rates: [[6000000]] is not of type 'object'
   arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml:
     adc@126c0000: assigned-clocks: [[7, 238]] is not of type 'object'

Does it mean that assigned-clocks related properties have to be added to 
almost all bindings?

To my understanding: yes, and we already added it to multiple schemas.

quoted

IMHO this is an over-engineering and this has to be 
handled somewhere else...

Would have to be made a part of the core schema (just like pinctrl nodes
etc).

That's the case now. It's contingent on having a 'clocks' property in 
the node.

Do I understand correctly: with new dtschema my patch is not needed anymore?

Best regards,
Krzysztof