Thread (36 messages) 36 messages, 4 authors, 2021-02-12

RE: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

From: Stefan Chulski <hidden>
Date: 2021-02-11 13:26:23
Also in: linux-arm-kernel, lkml, netdev

-----Original Message-----
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Sent: Thursday, February 11, 2021 2:50 PM
To: Stefan Chulski <redacted>
Cc: netdev@vger.kernel.org; thomas.petazzoni@bootlin.com;
davem@davemloft.net; Nadav Haklai [off-list ref]; Yan
Markman [off-list ref]; linux-kernel@vger.kernel.org;
kuba@kernel.org; mw@semihalf.com; andrew@lunn.ch;
atenart@kernel.org; devicetree@vger.kernel.org; robh+dt@kernel.org;
sebastian.hesselbarth@gmail.com; gregory.clement@bootlin.com; linux-
arm-kernel@lists.infradead.org
Subject: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non
occupied descriptor threshold

External Email

----------------------------------------------------------------------
On Thu, Feb 11, 2021 at 12:48:55PM +0200, stefanc@marvell.com wrote:
quoted
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 761f745..8b4073c 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -1133,14 +1133,19 @@ static inline void
mvpp2_qvec_interrupt_disable(struct mvpp2_queue_vector *qvec)  static
void mvpp2_interrupts_mask(void *arg)  {
 	struct mvpp2_port *port = arg;
+	int cpu = smp_processor_id();
+	u32 thread;

 	/* If the thread isn't used, don't do anything */
-	if (smp_processor_id() > port->priv->nthreads)
+	if (cpu > port->priv->nthreads)
 		return;
What happened to a patch fixing this? Did I miss it? Was it submitted
independently to the net tree?
Some reviewers asked to remove this from the series. I would send it as separate patch to net.

Regards.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help