Re: [PATCH] [RFC] dt-bindings: power: sysc-remobile: Convert to json-schema

From
Rob Herring <robh@kernel.org>
Date
2021-02-09 21:54:52
Also in
linux-pm, linux-renesas-soc, lkml
Reply to
Geert Uytterhoeven, 2021-01-27
On Wed, Jan 27, 2021 at 02:28:40PM +0100, Geert Uytterhoeven wrote:
Convert the Renesas R-Mobile System Controller (SYSC) Device Tree
binding documentation to json-schema.

Document missing properties.
Drop consumer example, as it does not belong here.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Marked RFC, as it does not check deeper levels than the first level of
the "pm-domains" subnode.

I think the reference in

    additionalProperties:
	$ref: "#/patternProperties"

should become "#/patternProperties/0/additionalProperties", but that
gives:

    Unresolvable JSON pointer: 'patternProperties/0/additionalProperties'
AFAIK, numbers only work on lists (such as 'allOf' values). So I think 
you'd want '#/patternProperties/^pm-domains$/additionalProperties'. 
However, regex's can have illegal characters. I think URI escaping them 
would work, but that gets too readable and unmaintainable for my tastes. 
The other way to do this is put the schema under a '$defs'. But in your 
case, you have just a fixed string, so there's no need for it to be a 
pattern. Just move it to 'properties'.

Otherwise, looks good to me.

Rob
Thread (3 messages) 3 messages, 3 authors, last reply 2021-03-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help