Re: [PATCH 00/16] net: stmmac: Add DW MAC GPIOs and Baikal-T1 GMAC support
From: Serge Semin <hidden>
Date: 2021-02-09 11:19:36
Also in:
linux-arm-kernel, lkml, netdev
On Mon, Feb 08, 2021 at 08:36:33PM +0100, Andrew Lunn wrote:
On Mon, Feb 08, 2021 at 05:08:04PM +0300, Serge Semin wrote: Hi Serge I suggest you split this patchset up. This uses the generic GPIO framework, which is great. But that also means you should be Cc: the GPIO subsystem maintainers and list. But you don't want to spam them with all the preparation work, which has little to do with the GPIO code. So please split the actual GPIO driver and DT binding patches from the rest. netdev can review the preparation work, with a comment in the 0/X patch about what the big picture is, and then afterwards review the GPIO patchset with a wider audience. And as Jakub pointed out, nobody is going to review 60 patches all at once. Please submit one series at a time, get it merged, and then move onto the next.
Hello Andrew Right, with all that preparation work I've forgotten to Cc the GPIO-subsystem maintainers. Thanks for noticing this. Regarding the 60-patches. Please see my response to Jakub' post in the first series. To cut it short let's start working with that patchset: Link: https://lore.kernel.org/netdev/20210208135609.7685-1-Sergey.Semin@baikalelectronics.ru/ (local) I'll rebase and resubmit the rest of the work when the time comes. Regarding splitting the series up. I don't see a problem in just sending the cover-letter patch and actual GPIO-related patches to the GPIO-maintainers with no need to have them added to Cc in the rest of the series. That's a normal practice. Splitting is not really required. But since I have to split the very first patchset anyway. I'll split this one up too, when it comes to have this part of changes reviewed. -Sergey
Andrew