Re: [PATCH 11/18] arm64: Kconfig: Require FIQ support for ARCH_APPLE

Started by Hector Martin 'marcan' on Feb 7, 2021

open the first message on its own page

Message details and related content
On 07/02/2021 00.46, Marc Zyngier wrote:
quoted
  config ARCH_APPLE
  	bool "Apple Silicon SoC family"
  	select GENERIC_IRQ_CHIP
+	select ARM64_FIQ_SUPPORT
Ah, this is what I was expecting in the previous patch. I guess the
initial ARCH_APPLE patch could be moved down the line and add all the
dependencies in one go.
I was trying to introduce the Kconfig before the code that depends on it; is it kosher to have it in the other order, looking for CONFIG_ defines that don't exist yet?

Though in this case the only user earlier in the series is the Samsung stuff, which doesn't care about FIQs, so I can just sort things as FIQ->ARCH_APPLE->samsung->AIC...

I'm not sure about AIC vs. ARCH_APPLE though. Right now the pattern is that AIC depends on ARCH_APPLE and also defaults to that. But then you can build with ARCH_APPLE and AIC disabled if you so choose, which does result in a broken system on these machines. AIC should build without ARCH_APPLE (as long as we're on ARM64), so we could reverse that.

-- 
Hector Martin "marcan" (marcan@marcan.st)
Public Key: https://mrcn.st/pub
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help