Thread (7 messages) 7 messages, 3 authors, 2021-02-06

AW: [PATCH v2 1/4] leds: lp50xx: add setting of default intensity from DT

From: Sven Schuchmann <hidden>
Date: 2021-02-06 00:56:00
Also in: linux-leds, lkml

Hello Pavel, hello Dan,
quoted
diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-
lp50xx.yaml
quoted
index c192b5feadc7..2bc25b2fc94d 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
@@ -65,6 +65,11 @@ patternProperties:
           This property denotes the LED module number(s) that is used on the
           for the child node.  The LED modules can either be used stand alone
           or grouped into a module bank.
+      default-intensity:
+        minItems: 1
+        maxItems: 3
+        description:
Do we need more than three for RGBW and similar?
AFAIK the lp50xx supports only RGB. So I would go for that.

quoted
     patternProperties:
       "(^led-[0-9a-f]$|led)":
@@ -99,6 +104,7 @@ examples:
                reg = <0x1>;
                color = <LED_COLOR_ID_RGB>;
                function = LED_FUNCTION_CHARGING;
+               default-intensity = <100 0 0>;

                led-0 {
                    color = <LED_COLOR_ID_RED>;
Should this go to leds-class-multicolor.yaml ? 
I think then all drivers should support it,  but I cannot change all drivers. 
So I would only leave it in there.

Can you make example
<255 120 0> or something like that, so make it clear it is not
percent?
Sure

Best Regards,

   Sven


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help