Re: [PATCH 2/2] leds: lp50xx: remove unused regulator

On Wed 2021-02-03 10:02:00, Dan Murphy wrote:

Pavel

On 2/3/21 8:23 AM, Pavel Machek wrote:

quoted

On Wed 2021-02-03 07:49:35, Dan Murphy wrote:

quoted

Pavel

On 2/3/21 3:02 AM, Pavel Machek wrote:

quoted

On Wed 2021-02-03 08:34:08, Sven Schuchmann wrote:

quoted

The regulator for vled-supply is unused in the driver.
It is just assigned from DT and disabled in lp50xx_remove.
So the code can be removed from the driver.

Dan, what is going on here? Do we need to also enable the regulator,
or is the removal correct thing to do?

I think it would be better to do an enable as opposed to removing the code.

This would be needed especially in applications that have to meet strict
power management requirements.

Users may want to disable or enable the regulator during suspend/resume.
Otherwise it would be considered always-on and the regulator does not need
to be populated.

Do you have set up where this is needed and you can test this? Will
you submit the fixes?

No I use an always on regulator in my setup. I have no managed supplies
exposed.

Hmm, that is not ideal :-(. Can you try to provide patch, anyway?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek