Thank you Heikki and Guenter for these valuable reviews.
I will update it in the next version.

thanks,
Kyle

On Wed, Feb 3, 2021 at 11:04 PM Heikki Krogerus
[off-list ref] wrote:

On Wed, Feb 03, 2021 at 05:01:26PM +0200, Heikki Krogerus wrote:

quoted

On Wed, Feb 03, 2021 at 06:51:43AM -0800, Guenter Roeck wrote:

quoted

Thinking about it, would it make make sense to define the functions as
static inline ?

I (and I believe Guenter too)

s/I believe Guenter too/I thought you too/

quoted

want to keep these structures protected
for now. If the API starts to get too bloated, then I guess I have to
reconsider that. But I don't think we are there yet.

I have been thinking about moving the USB PD negotiation details to a
separate structure that could be more accessible for everybody. That
should allow me continue to protect my precious structures. But I have
not yet put much though into that.

--
heikki