Re: [PATCH v2 0/2] of: property: Add fw_devlink support for more props
From: Martin Kaiser <hidden>
Date: 2021-02-01 10:53:05
Also in:
linux-tegra, lkml
Possibly related (same subject, not in this thread)
- 2021-01-26 · Re: [PATCH v2 0/2] of: property: Add fw_devlink support for more props · Greg Kroah-Hartman <gregkh@linuxfoundation.org>
- 2021-01-21 · [PATCH v2 0/2] of: property: Add fw_devlink support for more props · Saravana Kannan <hidden>
Hi Saravana, Thus wrote Saravana Kannan (saravanak@google.com):
This series [1] has a high chance of fixing it for you if CONFIG_MODULES is disabled in your set up. Can you give it a shot?
sure. This fixes things for me if CONFIG_MODULES is disabled. Booting is still stuck if modules are enabled.
The real problem is that arch/arm/mach-imx/avic.c doesn't set the OF_POPULATED flag for the "fsl,avic" node. fw_devlink uses this information to know that this device node will never have a struct device created for it. The proper way to do this for root IRQCHIP nodes is to use IRQCHIP_DECLARE(). I Cc'ed you on a clean up patch for IMX [2], can you please give [2] a shot *without* [1] and with CONFIG_MODULES enabled? Things should boot properly with this combination too.
This works as well. Thanks, Martin