Re: [PATCH v4 2/2] media: i2c: Add imx334 camera sensor driver

Hi Martina,

A few more comments.

On Fri, Dec 11, 2020 at 10:56:33AM +0000, Martina Krasteva wrote:

From: Martina Krasteva <redacted>

Add a v4l2 sub-device driver for the Sony imx334 image sensor.
This is a camera sensor using the i2c bus for control and the
csi-2 bus for data.

The following features are supported:
- manual exposure and analog gain control support
- vblank/hblank/pixel rate control support
- supported resolution:
    - 3840x2160 @ 60fps
- supported bayer order output:
    - SRGGB12

Could you add the external clock and link frequencies related properties to
the bindings and use them in the driver?

<URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html>

Apart from these it looks good to me.

-- 
Kind regards,

Sakari Ailus