Re: [RFC PATCH 0/6] Keem Bay OCS ECC crypto driver

On Fri, 2021-01-22 at 07:02 +1100, Herbert Xu wrote:

On Thu, Jan 21, 2021 at 04:13:51PM +0000, Alessandrelli, Daniele
wrote:

quoted

As expected, the second implementation does not pass self-tests and
crypto_alloc_kpp() returns -ELIBBAD when trying to allocate it, but
I've seen that I can avoid the error (and have it allocated
properly)
by passing the CRYPTO_ALG_TESTED flag in the 'type' argument, like
below:

Did you set your algorithm's name to ecdh? I think Ard was suggesting
you to not do that.  As long as you're not using the same name as a
recognised algorithm, then you won't need to pass any self-tests at
all.

Oh, looks like I misunderstood Ard suggestion.

I will change the second implementation to use a different algorithm
name (cra_name), something like 'ecdh-keembay-ocs'.

Thanks,
Daniele