Re: [PATCH net-next v4 1/3] dsa: add support for Arrow XRS700x tag trailer

On Thu, Jan 14, 2021 at 03:05:19AM +0200, Vladimir Oltean wrote:

On Wed, Jan 13, 2021 at 08:59:20AM -0600, George McCollister wrote:

quoted

Add support for Arrow SpeedChips XRS700x single byte tag trailer. This
is modeled on tag_trailer.c which works in a similar way.

Signed-off-by: George McCollister <george.mccollister@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

A few comments below.

quoted

diff --git a/net/dsa/tag_xrs700x.c b/net/dsa/tag_xrs700x.c
new file mode 100644
index 000000000000..4ee7c260a8a9
--- /dev/null
+++ b/net/dsa/tag_xrs700x.c

@@ -0,0 +1,67 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * XRS700x tag format handling
+ * Copyright (c) 2008-2009 Marvell Semiconductor

Why does Marvell get copyright?

Probably because it started life as tag_trailer.c?

	 Andrew