Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges

On 2021-01-27 19:09, Rob Herring wrote:

On Wed, Jan 27, 2021 at 7:13 AM Robin Murphy [off-list ref] wrote:

quoted

[ + Christoph, Marek ]

On 2021-01-27 13:00, Paul Kocialkowski wrote:

quoted

Hi,

On Tue 19 Jan 21, 18:52, Yong Wu wrote:

quoted

The commit e0d072782c73 ("dma-mapping: introduce DMA range map,
supplanting dma_pfn_offset") always update dma_range_map even though it was
already set, like in the sunxi_mbus driver. the issue is reported at [1].
This patch avoid this(Updating it only when dev has valid dma-ranges).

Meanwhile, dma_range_map contains the devices' dma_ranges information,
This patch moves dma_range_map before of_iommu_configure. The iommu
driver may need to know the dma_address requirements of its iommu
consumer devices.

Just a gentle ping on this issue, it would be nice to have this fix merged
ASAP, in the next RC :)

Ack to that - Rob, Frank, do you want to take this through the OF tree,
or shall we take it through the DMA-mapping tree like the original culprit?

I've already got some fixes queued up and can take it.

Brilliant, thanks!

Suggested-by doesn't mean you are happy with the implementation. So
Acked-by or Reviewed-by?

It still feels slightly awkward to give a tag to say "yes, this is 
exactly what I suggested", but for the avoidance of doubt,

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

Cheers,
Robin.