On Tue, Jan 19, 2021 at 11:20:24AM +0100, Linus Walleij wrote:

On Tue, Jan 19, 2021 at 9:50 AM Geert Uytterhoeven [off-list ref] wrote:

quoted

quoted

Can we pull this into driver-core-next please? It fixes issues on some
boards with fw_devlink=on.

On r8a77951-salvator-xs.dts, it introduces one more failure:

    OF: /soc/i2c@e66d8000/gpio@20/pcie-sata-switch-hog: could not get
#gpio-cells for /cpus/cpu@102

Seems like it doesn't parse gpios properties in GPIO hogs correctly.

Could it be that the code assumes no self-referencing phandles?
(Just guessing...)

Well, since this is scanning the DT and creating device links between
producers and consumers, there's really no point in handling self-
references, so I think that's fine.

However, what this probably should do is skip the node if it's marked
as a GPIO hog to avoid the error message.

Thierry