Re: [PATCH V2 4/4] net: ethernet: ravb: Enable optional refclk
From: Sergei Shtylyov <hidden>
Date: 2021-01-16 09:56:09
Also in:
linux-renesas-soc, lkml, netdev
Hello! On 15.01.2021 23:19, Adam Ford wrote:
For devices that use a programmable clock for the avb reference clock,
AVB.
the driver may need to enable them. Add code to find the optional clock and enable it when available. Signed-off-by: Adam Ford <redacted>
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index bd30505fbc57..739e30f45daa 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c@@ -2148,6 +2148,14 @@ static int ravb_probe(struct platform_device *pdev) goto out_release; } + priv->refclk = devm_clk_get_optional(&pdev->dev, "refclk"); + if (IS_ERR(priv->refclk)) { + error = PTR_ERR(priv->refclk); + goto out_release; + } else {
No need for *else* after *goto*.
+ (void)clk_prepare_enable(priv->refclk);
You can really omit (void)...
Also, I'm not seeing where do you call clk_disable_unprepare()...
[...]
MBR, Sergei