Re: [PATCH 04/15] dt_bindings: bd71828: Add clock output mode
From: Rob Herring <robh@kernel.org>
Date: 2021-01-13 13:53:03
Also in:
linux-clk, lkml
On Fri, Jan 08, 2021 at 03:34:16PM +0200, Matti Vaittinen wrote:
quoted hunk ↗ jump to hunk
The BD71828 allows configuring the clk32kout pin mode to CMOS or open-drain. Add device-tree property for specifying the preferred mode. Signed-off-by: Matti Vaittinen <redacted> --- .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml index 3a6a1a26e2b3..cba085836bc0 100644 --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml@@ -44,6 +44,13 @@ properties: clock-output-names: const: bd71828-32k-out + rohm,clkout-mode: + description: clk32kout mode. Can be set to "open-drain" or "cmos". + $ref: "/schemas/types.yaml#/definitions/string" + enum: + - open-drain + - cmos +
I think a boolean or tristate ((0/1/not present) if you need 'leave default') would be better.
rohm,charger-sense-resistor-ohms:
minimum: 10000000
maximum: 50000000
--
2.25.4
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]