Re: [PATCH v3 1/2] arm64: dts: mt8183: config dsi node
From: Enric Balletbo i Serra <hidden>
Date: 2021-01-13 10:34:25
Also in:
linux-arm-kernel, linux-mediatek, lkml
Hi Hsin-Yi, Thank you for the patch. On 13/1/21 7:28, Hsin-Yi Wang wrote:
quoted hunk ↗ jump to hunk
Config dsi node for mt8183 kukui. Set panel and ports. Several kukui boards share the same panel property and only compatible is different. So compatible will be set in board dts for comparison convenience. Signed-off-by: Hsin-Yi Wang <redacted> Reviewed-by: Nicolas Boichat <redacted> --- .../mediatek/mt8183-kukui-krane-sku176.dts | 5 +++ .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 37 +++++++++++++++++++ 2 files changed, 42 insertions(+)diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts index 47113e275cb52..721d16f9c3b4f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts@@ -16,3 +16,8 @@ / { model = "MediaTek krane sku176 board"; compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183"; }; + +&panel { + status = "okay"; + compatible = "boe,tv101wum-nl6"; +};diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index bf2ad1294dd30..c5f41b94f154e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi@@ -249,6 +249,35 @@ &cpu7 { proc-supply = <&mt6358_vproc11_reg>; }; +&dsi0 { + status = "okay"; + #address-cells = <1>; + #size-cells = <0>; + panel: panel@0 { + /* compatible will be set in board dts */ + reg = <0>; + enable-gpios = <&pio 45 0>; + pinctrl-names = "default"; + pinctrl-0 = <&panel_pins_default>; + avdd-supply = <&ppvarn_lcd>; + avee-supply = <&ppvarp_lcd>; + pp1800-supply = <&pp1800_lcd>;
It'd make sense to add also the backlight here? + backlight = <&backlight_lcd0>;
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&dsi_out>;
+ };
+ };
+ };
+
+ ports {
+ port {
+ dsi_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+ };
+};
+
I think you should enable the MIPI TX to have DSI and panel working?
+&mipi_tx0 {
+ status = "okay";
+};
quoted hunk ↗ jump to hunk
&i2c0 { pinctrl-names = "default"; pinctrl-0 = <&i2c0_pins>;@@ -547,6 +576,14 @@ pins_clk { }; }; + panel_pins_default: panel_pins_default { + panel_reset { + pinmux = <PINMUX_GPIO45__FUNC_GPIO45>; + output-low; + bias-pull-up; + }; + }; + pwm0_pin_default: pwm0_pin_default { pins1 { pinmux = <PINMUX_GPIO176__FUNC_GPIO176>;