Re: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property
From: Stephen Boyd <hidden>
Date: 2021-01-12 02:11:22
Also in:
linux-input, lkml
Quoting Philip Chen (2021-01-07 15:42:08)
This patch adds a new property `function-row-physmap` to the
From Documentation/process/submitting-patches.rst Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
quoted hunk ↗ jump to hunk
device tree for the custom keyboard top row design. The property describes the rows/columns of the top row keys from left to right. Signed-off-by: Philip Chen <redacted> ---diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml index 8e50c14a9d778..7acdb33781d30 100644 --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml@@ -31,6 +31,16 @@ properties: if the EC does not have its own logic or hardware for this. type: boolean + function-row-physmap:
Is there any minimum/maximum number of elements possible?
+ $ref: '/schemas/types.yaml#/definitions/uint32-array' + description: | + An ordered u32 array describing the rows/columns (in the scan matrix) + of top row keys from physical left (KEY_F1) to right. Each entry + encodes the row/column as: + (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16) + where the lower 16 bits are reserved. This property is specified only + when the keyboard has a custom design for the top row keys. +