Thread (11 messages) 11 messages, 3 authors, 2021-01-07

Re: [PATCH v3 0/3] Support wakeup methods of Atmel maXTouch controllers

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2021-01-07 22:06:17
Also in: linux-input, linux-tegra, lkml

13.12.2020 12:26, Dmitry Osipenko пишет:
quoted hunk ↗ jump to hunk
13.12.2020 07:41, Dmitry Torokhov пишет:
quoted
Thank you for the logs. I am confused where these calls to put the
controller into deep sleep are coming from. Does something constantly
open and close input device?
Input devices are re-opened multiple times during Linux distro boot-up,
a regular Ubuntu 20.10 in this case.
quoted
Do you have any additional patches?
No, I'm using next-20201211 + this "wakeup methods" patchset.
quoted
We definitely do not issue deep sleep request in mxt_start(). Do you mind
putting dump_stack() into mxt_set_t7_power_cfg() to see where the calls
are coming from?
Please see the log below, I added it like this:
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
b/drivers/input/touchscreen/atmel_mxt_ts.c
index e3342fdfe9f3..bbc5a5ee158a 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -2271,6 +2271,8 @@ static int mxt_set_t7_power_cfg(struct mxt_data
*data, u8 sleep)
 	dev_dbg(dev, "Set T7 ACTV:%d IDLE:%d\n",
 		new_config->active, new_config->idle);

+	dump_stack();
+
 	return 0;
 }
quoted
I also do not see additional "waking up controller" messages after
requesting the chip via T7 to be configured to be active, which I'd
expected to see if we indeed needed to wake it up again for T6 to
succeed.
I'm not familiar with what controller does internally, hence no clue.


[ 1.195295] Family: 160 Variant: 0 Firmware V1.0.AA Objects: 18
[ 1.195468] T37 Start:118 Size:130 Instances:1 Report IDs:0-0
...
Dmitry Torokhov, do you have any more comments? Are you okay with v3? If
yes, could you please pick up patches into -next?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help