Re: [PATCH v4 5/7] power: reset: Add poweroff driver for ATC260x PMICs
From: Sebastian Reichel <hidden>
Date: 2021-01-03 03:27:33
Also in:
linux-input, linux-pm, lkml
Hi, On Tue, Dec 29, 2020 at 07:31:20PM +0200, Cristian Ciocaltea wrote:
quoted hunk ↗ jump to hunk
This driver provides poweroff and reboot support for a system through the ATC2603C and ATC2609A chip variants of the Actions Semi ATC260x family of PMICs. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> --- Changes in v4: - None Changes in v3: - Removed the unnecessary driver compatibles drivers/power/reset/Kconfig | 8 +- drivers/power/reset/Makefile | 1 + drivers/power/reset/atc260x-poweroff.c | 263 +++++++++++++++++++++++++ 3 files changed, 271 insertions(+), 1 deletion(-) create mode 100644 drivers/power/reset/atc260x-poweroff.cdiff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig index b22c4fdb2561..1737e227b16e 100644 --- a/drivers/power/reset/Kconfig +++ b/drivers/power/reset/Kconfig@@ -39,6 +39,13 @@ config POWER_RESET_AT91_SAMA5D2_SHDWC This driver supports the alternate shutdown controller for some Atmel SAMA5 SoCs. It is present for example on SAMA5D2 SoC. +config POWER_RESET_ATC260X + tristate "Actions Semi ATC260x PMIC power-off driver" + depends on MFD_ATC260X + help + This driver provides power-off and restart support for a system + through Actions Semi ATC260x series PMICs. + config POWER_RESET_AXXIA bool "LSI Axxia reset driver" depends on ARCH_AXXIA@@ -292,4 +299,3 @@ config NVMEM_REBOOT_MODE action according to the mode. endif -diff --git a/drivers/power/reset/Makefile b/drivers/power/reset/Makefile index 9dc49d3a57ff..b4601c0a96ed 100644 --- a/drivers/power/reset/Makefile +++ b/drivers/power/reset/Makefile@@ -3,6 +3,7 @@ obj-$(CONFIG_POWER_RESET_AS3722) += as3722-poweroff.o obj-$(CONFIG_POWER_RESET_AT91_POWEROFF) += at91-poweroff.o obj-$(CONFIG_POWER_RESET_AT91_RESET) += at91-reset.o obj-$(CONFIG_POWER_RESET_AT91_SAMA5D2_SHDWC) += at91-sama5d2_shdwc.o +obj-$(CONFIG_POWER_RESET_ATC260X) += atc260x-poweroff.o obj-$(CONFIG_POWER_RESET_AXXIA) += axxia-reset.o obj-$(CONFIG_POWER_RESET_BRCMKONA) += brcm-kona-reset.o obj-$(CONFIG_POWER_RESET_BRCMSTB) += brcmstb-reboot.odiff --git a/drivers/power/reset/atc260x-poweroff.c b/drivers/power/reset/atc260x-poweroff.c new file mode 100644 index 000000000000..81b050f99302 --- /dev/null +++ b/drivers/power/reset/atc260x-poweroff.c@@ -0,0 +1,263 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Poweroff & reset driver for Actions Semi ATC260x PMICs + * + * Copyright (c) 2020 Cristian Ciocaltea <cristian.ciocaltea@gmail.com> + */ + +#include <linux/delay.h> +#include <linux/mfd/atc260x/core.h> +#include <linux/module.h> +#include <linux/of.h>
There is no DT code in this driver?
+#include <linux/platform_device.h> +#include <linux/power_supply.h>
power_supply.h? That's for chargers and battery fuel gauges.
+#include <linux/reboot.h> +#include <linux/regmap.h>
[...]
Otherwise LGTM. I suppose I can cherry-pick this patch into my tree, or did I miss some dependencies? -- Sebastian
Attachments
- signature.asc [application/pgp-signature] 833 bytes