Re: [PATCH 08/46] dt-bindings:iio:health:ti,afe4404: txt to yaml conversion

On Fri, 18 Dec 2020 13:42:19 -0600
Rob Herring [off-list ref] wrote:

On Sat, Oct 31, 2020 at 1:51 PM Jonathan Cameron [off-list ref] wrote:

quoted

From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

This basically has same questions as for the afe4403.  We could combine
the two bindings, but as the drivers are separate and it would be a little
fiddly due to different buses let's keep the separating.
To repeat questions from the ti,afe4403 binding.

A few questions came up whilst converting this one.
1) What is actually required?
   - Checking Linux driver, interrupt is not, and the tx-supply could
     be supplied by a stub regulator as long as it's always on.
     As such I have reduced the required list to just compatible and reg.
2) What is the regulator called?
   - It's tx-supply in the binding doc, but the driver request tx_sup
     I've left this alone for now.  Andrew could you confirm what is
     intended for this?

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Andrew F. Davis <redacted>
---
 .../bindings/iio/health/afe4404.txt           | 29 -----------
 .../bindings/iio/health/ti,afe4404.yaml       | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 29 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/health/afe4404.txt b/Documentation/devicetree/bindings/iio/health/afe4404.txt
deleted file mode 100644
index 0b52830a0d9c..000000000000
--- a/Documentation/devicetree/bindings/iio/health/afe4404.txt
+++ /dev/null

@@ -1,29 +0,0 @@
-Texas Instruments AFE4404 Heart rate and Pulse Oximeter
-
-Required properties:
- - compatible          : Should be "ti,afe4404".
- - reg                 : I2C address of the device.
- - tx-supply           : Regulator supply to transmitting LEDs.
- - interrupts          : The interrupt line the device ADC_RDY pin is
-                         connected to. For details refer to,
-                         ../interrupt-controller/interrupts.txt.
-
-Optional properties:
- - reset-gpios         : GPIO used to reset the device.
-                         For details refer to, ../gpio/gpio.txt.
-
-Example:
-
-&i2c2 {
-       heart_mon@58 {
-               compatible = "ti,afe4404";
-               reg = <0x58>;
-
-               tx-supply = <&vbat>;
-
-               interrupt-parent = <&gpio1>;
-               interrupts = <28 IRQ_TYPE_EDGE_RISING>;
-
-               reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
-       };
-};

diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
new file mode 100644
index 000000000000..187b99b22312
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml

@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/ti,afe4404.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments AFE4404 Heart rate and Pulse Oximeter
+
+maintainers:
+  - Andrew F. Davis <afd@ti.com>
+
+properties:
+  compatible:
+    const: ti,afe4403  

Typo here, which causes this warning:

Documentation/devicetree/bindings/iio/health/ti,afe4403.example.dt.yaml:
heart_mon@0: 'spi-max-frequency' does not match any of the regexes:
'pinctrl-[0-9]+'

Took me a minute staring at ti,afe4403.yaml to figure out what was happening.

Doh!

Patch on it's way.

Thanks,

Jonathan

Rob