Re: [PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

Hi George,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/George-McCollister/Arrow-SpeedChips-XRS700x-DSA-Driver/20201208-060957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b1f7b0983601af4054876bca42e3094bf6b034c0
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/17e19d3e01ec0a36ca45992b96580d271e9f6f75
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review George-McCollister/Arrow-SpeedChips-XRS700x-DSA-Driver/20201208-060957
        git checkout 17e19d3e01ec0a36ca45992b96580d271e9f6f75
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

   drivers/net/dsa/xrs700x/xrs700x.c:511:3: error: 'const struct dsa_switch_ops' has no member named 'get_stats64'
     511 |  .get_stats64  = xrs700x_getstats64,
         |   ^~~~~~~~~~~
   drivers/net/dsa/xrs700x/xrs700x.c:511:18: error: initialization of 'int (*)(struct dsa_switch *, int,  int)' from incompatible pointer type 'void (*)(struct dsa_switch *, int,  struct rtnl_link_stats64 *)' [-Werror=incompatible-pointer-types]
     511 |  .get_stats64  = xrs700x_getstats64,
         |                  ^~~~~~~~~~~~~~~~~~
   drivers/net/dsa/xrs700x/xrs700x.c:511:18: note: (near initialization for 'xrs700x_ops.get_sset_count')

quoted

drivers/net/dsa/xrs700x/xrs700x.c:511:18: warning: initialized field overwritten [-Woverride-init]

   drivers/net/dsa/xrs700x/xrs700x.c:511:18: note: (near initialization for 'xrs700x_ops.get_sset_count')
   cc1: some warnings being treated as errors

vim +511 drivers/net/dsa/xrs700x/xrs700x.c

   500	
   501	static const struct dsa_switch_ops xrs700x_ops = {
   502		.get_tag_protocol	= xrs700x_get_tag_protocol,
   503		.setup			= xrs700x_setup,
   504		.teardown		= xrs700x_teardown,
   505		.port_stp_state_set	= xrs700x_port_stp_state_set,
   506		.phylink_validate	= xrs700x_phylink_validate,
   507		.phylink_mac_link_up	= xrs700x_mac_link_up,
   508		.get_strings		= xrs700x_get_strings,
   509		.get_sset_count		= xrs700x_get_sset_count,
   510		.get_ethtool_stats	= xrs700x_get_ethtool_stats,
 > 511		.get_stats64		= xrs700x_getstats64,
   512		.port_bridge_join	= xrs700x_bridge_join,
   513		.port_bridge_leave	= xrs700x_bridge_leave,
   514	};
   515	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org