Re: [PATCH 8/8] mmc: sdhci-msm: add Inline Crypto Engine support

On Wed, Dec 02, 2020 at 03:56:21PM +0200, Adrian Hunter wrote:

quoted

+/* Poll until all BIST (built-in self test) bits are reset */
+static int sdhci_msm_ice_wait_bist_status(struct sdhci_msm_host *msm_host)
+{
+	int count;
+	u32 reg;
+
+	for (count = 0; count < 100; count++) {
+		reg = sdhci_msm_ice_readl(msm_host, QCOM_ICE_REG_BIST_STATUS);
+		if (!(reg & QCOM_ICE_BIST_STATUS_MASK))
+			break;
+		udelay(50);

usleep_range ?

Also could use read_poll_timeout() here

I'll change it to use readl_poll_timeout().

- Eric