Re: [PATCH v3 1/7] dt-bindings: input: Add reset-time-sec common property
From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Date: 2020-12-10 09:26:23
Also in:
linux-input, linux-pm, lkml
From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Date: 2020-12-10 09:26:23
Also in:
linux-input, linux-pm, lkml
Hi Mani, On Thu, Dec 10, 2020 at 09:36:44AM +0530, Manivannan Sadhasivam wrote:
On Sun, Dec 06, 2020 at 03:27:01AM +0200, Cristian Ciocaltea wrote:quoted
Add a new common property 'reset-time-sec' to be used in conjunction with the devices supporting the key pressed reset feature. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com> --- Changes in v3: - This patch was not present in v2 Documentation/devicetree/bindings/input/input.yaml | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/Documentation/devicetree/bindings/input/input.yaml b/Documentation/devicetree/bindings/input/input.yaml index ab407f266bef..caba93209ae7 100644 --- a/Documentation/devicetree/bindings/input/input.yaml +++ b/Documentation/devicetree/bindings/input/input.yaml@@ -34,4 +34,11 @@ properties: specify this property. $ref: /schemas/types.yaml#/definitions/uint32 + reset-time-sec: + description: + Duration in seconds which the key should be kept pressed for device to + reset automatically. Device with key pressed reset feature can specify + this property. + $ref: /schemas/types.yaml#/definitions/uint32 +Why can't you just use "power-off-time-sec"?
I think the common behavior of keeping the power button pressed is to trigger a power off rather than a reset. Hence, per Rob's suggestion in the previous revision of this patch series, I added the reset variant: https://lore.kernel.org/lkml/20200908214724.GA959481@bogus/ (local) Thanks, Cristi
Thanks, Maniquoted
additionalProperties: true -- 2.29.2