Thread (28 messages) 28 messages, 5 authors, 2020-12-02

Re: [PATCH net-next v2 1/3] dsa: add support for Arrow XRS700x tag trailer

From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-11-25 20:34:34
Also in: netdev

+static struct sk_buff *xrs700x_rcv(struct sk_buff *skb, struct net_device *dev,
+				   struct packet_type *pt)
+{
+	int source_port;
+	u8 *trailer;
+
+	if (skb_linearize(skb))
+		return NULL;
Something for Vladimir:

Could this linearise be moved into the core, depending on the
tail_tag?
+	if (pskb_trim_rcsum(skb, skb->len - 1))
+		return NULL;
And the overhead is also in dsa_devlink_ops, so maybe this can be
moved as well?

      Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help