Thread (18 messages) 18 messages, 5 authors, 2020-12-10

Re: [PATCH 2/4] dma-buf: add export symbol for dma-heap

From: John Stultz <hidden>
Date: 2020-11-18 05:18:32
Also in: linux-media, linux-mm, lkml

On Tue, Nov 17, 2020 at 10:19 AM Minchan Kim [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Hyesoo Yu <redacted>

The heaps could be added as module, so some functions should
be exported to register dma-heaps. And dma-heap of module can use
cma area to allocate and free. However the function related cma
is not exported now. Let's export them for next patches.

Signed-off-by: Hyesoo Yu <redacted>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 drivers/dma-buf/dma-heap.c | 2 ++
 mm/cma.c                   | 3 +++
 2 files changed, 5 insertions(+)
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
index afd22c9dbdcf..cc6339cbca09 100644
--- a/drivers/dma-buf/dma-heap.c
+++ b/drivers/dma-buf/dma-heap.c
@@ -189,6 +189,7 @@ void *dma_heap_get_drvdata(struct dma_heap *heap)
 {
        return heap->priv;
 }
+EXPORT_SYMBOL_GPL(dma_heap_get_drvdata);

 struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info)
 {
@@ -272,6 +273,7 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info)
        kfree(heap);
        return err_ret;
 }
+EXPORT_SYMBOL_GPL(dma_heap_add);

 static char *dma_heap_devnode(struct device *dev, umode_t *mode)
 {
Thanks so much for sending this series along!
I'm ok with the dma-heap exports to support modules.
quoted hunk ↗ jump to hunk
diff --git a/mm/cma.c b/mm/cma.c
index 7c11ec2dc04c..87834e2966fa 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -54,6 +54,7 @@ const char *cma_get_name(const struct cma *cma)
 {
        return cma->name;
 }
+EXPORT_SYMBOL_GPL(cma_get_name);

 static unsigned long cma_bitmap_aligned_mask(const struct cma *cma,
                                             unsigned int align_order)
@@ -498,6 +499,7 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align,
        pr_debug("%s(): returned %p\n", __func__, page);
        return page;
 }
+EXPORT_SYMBOL_GPL(cma_alloc);

 /*
  * cma_alloc_bulk() - allocate high order bulk pages from contiguous area with
@@ -641,6 +643,7 @@ bool cma_release(struct cma *cma, const struct page *pages, unsigned int count)

        return true;
 }
+EXPORT_SYMBOL_GPL(cma_release);

 int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data)
 {
--
Though Christoph's (cc'ed) input would probably be good for the cma
ones, as I know he had concerns previously with similar patches.

thanks
-john
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help