Re: [PATCH net-next v2 05/11] dt-bindings: net: dsa: microchip,ksz: add interrupt property
From: Christian Eggers <ceggers@arri.de>
Date: 2020-11-13 18:58:21
Also in:
lkml, netdev
On Friday, 13 November 2020, 00:07:32 CET, Vladimir Oltean wrote:
On Thu, Nov 12, 2020 at 04:35:31PM +0100, Christian Eggers wrote:quoted
The devices have an optional interrupt line. Signed-off-by: Christian Eggers <ceggers@arri.de> --- .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yamlb/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml index 431ca5c498a8..b2613d6c97cf 100644--- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
...
quoted
+ interrupt-parent = <&gpio5>; + interrupts = <1 IRQ_TYPE_LEVEL_LOW>; /* INTRP_N line */Isn't it preferable to use this syntax? interrupts-extended = <&gpio5 1 IRQ_TYPE_LEVEL_LOW>; /* INTRP_N line */
After reading Documentation/devicetree/bindings/interrupt-controller/interrupts.txt, I would say that "interrupts-extended" is more flexible as it allows different interrupt parents for the case there is more than one interrupt line. Although there is only one line on the KSZ, I will change this.