On Mon, 02 Nov 2020, Shihlun.Lin wrote:
Hi Lee,
Thank you for your time for checking my submission.
quoted
On Thu, 29 Oct 2020, Shihlun Lin wrote:
quoted
This is one of sub-device driver for Advantech embedded controller
AHC1EC0. This driver provides sysfs ABI for Advantech related
applications to monitor the system status.
Signed-off-by: Shihlun Lin <redacted>
Reported-by: kernel test robot <redacted>
LKP reported that your driver needed upstreaming?
I'm confused!
When I submitted the driver first time, LKP reported some warning to me and ask me to add the tag.
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>
Link: https://www.spinics.net/lists/kernel/msg3698194.html
That would only be for the fix.
Having a test robot report a missing driver seems odd.
quoted
quoted
---
drivers/mfd/Kconfig | 8 +
drivers/mfd/Makefile | 1 +
drivers/mfd/ahc1ec0-hwmon.c | 1514
+++++++++++++++++++++++++++++++++++
This obviously belongs in drivers/hwmon.
Thank you so much, I will do it.
quoted
quoted
3 files changed, 1523 insertions(+)
create mode 100644 drivers/mfd/ahc1ec0-hwmon.c
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 965bcafbe5b2..52ca49b211fc 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -2175,5 +2175,13 @@ config MFD_AHC1EC0
provides expose functions for sub-devices to read/write the value
to embedded controller.
+config MFD_AHC1EC0_HWMON
+ tristate "Advantech EC Hareware Monitor Function"
+ depends on MFD_AHC1EC0
+ help
+ This is sub-device for Advantech embedded controller AHC1EC0. This
+ driver provides the sysfs attribues for applications to monitor
+ the system status.
+
endmenu
endif
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 80a9a2bdc3ba..eb645db817b5 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -269,3 +269,4 @@ obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) +=
simple-mfd-i2c.o
quoted
obj-$(CONFIG_MFD_INTEL_M10_BMC) += intel-m10-bmc.o
obj-$(CONFIG_MFD_AHC1EC0) += ahc1ec0.o
+obj-$(CONFIG_MFD_AHC1EC0_HWMON) += ahc1ec0-hwmon.o
diff --git a/drivers/mfd/ahc1ec0-hwmon.c b/drivers/mfd/ahc1ec0-hwmon.c
new file mode 100644
index 000000000000..3e493b040b4a
--- /dev/null
+++ b/drivers/mfd/ahc1ec0-hwmon.c
@@ -0,0 +1,1514 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/**************************************************************
***************
quoted
+ * Copyright (c) 2018, Advantech Automation Corp.
You can't just lift a whole driver from downstream code and send it to
the mailing list as-is.
Could you give me more advice about how to submit the whole driver?
Is there any website to guide me?
There is lots of documentation on how to upstream code/drivers in
the /Documentation folder.
Start here:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Note, this online document, along with all of the others you will
required are actually contained in /Documentation, in the kernel
source tree.
Thank you so much.
quoted
quoted
+ * THIS IS AN UNPUBLISHED WORK CONTAINING CONFIDENTIAL AND
PROPRIETARY
quoted
+ * INFORMATION WHICH IS THE PROPERTY OF ADVANTECH AUTOMATION
CORP.
quoted
+ *
+ * ANY DISCLOSURE, USE, OR REPRODUCTION, WITHOUT WRITTEN
AUTHORIZATION FROM
quoted
+ * ADVANTECH AUTOMATION CORP., IS STRICTLY PROHIBITED.
+
****************************************************************
*************
This warning is in contradiction to the licence you are proposing.
Thank you so much, I will remove it.
You'd better seek proper permission from your legal department before
doing so. Subverting licence agreements can land you in heaps of
trouble if you're not careful.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog